-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Update Elastic Agent dashboard, package icon, and data stream mappings #1529
Conversation
Pinging @elastic/fleet (Team:Fleet) |
27d1b91
to
629c8c6
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
629c8c6
to
0d1e803
Compare
0d1e803
to
89b086b
Compare
@nchaulet I don't see cgroup memory information. Can you please add that as well. Both CPU and memory limits are critical in the container (Docker)environment and showing cgroup information would be very useful there. |
@matschaffer I know you have some great field experience and love to hear any feedback from your side on this Elastic Agent dashboard. |
e6a2ed0
to
9d60e84
Compare
We add a lot of fields to each template. Do we really need all of them? In general we should only map the ones we need in the queries for the dashboards. For all the other ones runtime fields could be used if needed. @nimarezainia Would be great if you could spin this up and have a look if all works as expected. |
We probably do not need any of them, I am going to use runtime fields instead |
@ruflin Actually looks like we do not support runtime fields in a package for now (elastic/package-spec#39) just going to cleanup the fields to only add the one needed in the dashboard |
@nchaulet We haven't added all the fields in the dashboard that the current beats shows. the idea was to make enough things available but users can easily extend the dashboard where needed.Can we make sure some of the missing fields in Events rate, Throughput (Bytes received), System load are available to user for easily extending the dashboard? |
I did not mean runtime fields on the packages / templates but on query time. |
Maybe I am saying a mistake here, but I think the only way to use runtime fields in a dashboard or a visualization is to add the runtime field to the index pattern |
I added the mappings for all the events, and throughput even the one we do not use in the dashboard. |
@hop-dev was looking at elastic/beats#27404 and found that
|
It does not but I can try to add it back and see if it solve the Fleet issue. |
@nchaulet is there a doc that'll teach me how to get this running live so I can see what's available? A couple of thoughts just based on the screenshot:
|
@matschaffer Here some docs on how to get this setup for testing: https://github.com/elastic/integrations/blob/master/docs/developer_workflow_design_build_test_integration.md |
@nchaulet You are right about the Kibana index pattern and runtime fields. I was thinking the user would update these to use it. But these are global and not per dashboard and I think there is also a chance to we will overwrite it? I'm hoping in the future each Dashboard will have its own "data view / kibana index pattern" stored locally so it does not impact each other and we do not overwrite it. I know there is some work ongoing in this direction on the Kibana side. Maybe @joshdover has some more specifics. |
@jen-huang My bad I misread your comment, I just pushed a fix for #1453 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I can't comment on the individual fields but based on the dashboard this looks good. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in Fleet/Integrations UI's. 🚀
Hi @nchaulet We have attempted to validate above ticket on 7.15 BC2 Kibana QA build and could not find required changes on elastic agent metrics dashboard for default docker-fleet-agent. Though we have enabled logs collection settings for default fleet server agent. @nchaulet Could you Please let us know how to validate above changes on dashboard. Working fine:
cc @EricDavisX Thanks |
Hi @EricDavisX
Build details:
Thanks |
Hi @nchaulet We have validated above PR again on 7.15BC4 cloud-qa build and came up with following observations shared above on Elastic-agent package version 1.2.0. Please let us know if we are missing anything in validating above. Observations:
Query: No data is available on graphs Cgroup CPUusage and [Elastic Agent] Errors in writing the response from the output. Is it expected. Thanks |
@dikshachauhan-qasource thanks for the testing The default filter issue will be fixed by #1569 For the no data for cgroup and errors it's expected, you will have data in cgroup if you run the agent in a container with memory and cpu limit. and errors if there are output errors. |
Description
Resolve #951
Resolve elastic/beats#27405
Resolve #1453
Update the elastic agent dashboard with more metrics:
Data streams changes:
beat*
fields to the metrics data_streamlog.level
field to fix a bug with the log level selection in the agent logs page in FleetUI Change
cc @ravikesarwani